Fixed the issue of the main page getting stuck due to the long execution time required for updates #17626
+118
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion time required for updates
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Sep 12, 2024
| @@ -58,6 +58,7 @@ class CC_EX_DLL AssetsManagerEx : public RefCounted { | |||
| DOWNLOADING_MANIFEST, | |||
| MANIFEST_LOADED, | |||
| NEED_UPDATE, | |||
| PARPER_UPDATING, | |||
There was a problem hiding this comment.
Indicates that the prepare update function is being processed
minggo
reviewed
Sep 12, 2024
|
|
||
| void AssetsManagerEx::prepareUpdateAsync(const PrepareUpdateFinishedCallback &cb) { | ||
| // Avoiding multiple function calls. | ||
| if (_updateState != State::NEED_UPDATE || _updateState == State::PARPER_UPDATING) { |
There was a problem hiding this comment.
It is better to print a warning log.
added 2 commits
September 12, 2024 10:25
minggo
approved these changes
Sep 13, 2024
zhitaocai
pushed a commit
to zhitaocai/cocos-engine
that referenced
this pull request
Oct 18, 2024
…ion time required for updates (cocos#17626) * Fixed the issue of the main page getting stuck due to the long execution time required for updates --------- Co-authored-by: qgh <>
AILHC
pushed a commit
to AILHC/cocos-engine
that referenced
this pull request
Oct 19, 2024
…ion time required for updates (cocos#17626) * Fixed the issue of the main page getting stuck due to the long execution time required for updates --------- Co-authored-by: qgh <> (cherry picked from commit c679595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
#17544
Continuous Integration
This pull request:
Compatibility Check
This pull request: